[Bug 1232580] Review Request: purple-line - libpurple (Pidgin, Finch) protocol plugin for LINE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1232580

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Issues:
1) rpmlint on all generated rpms gave output as
purple-line.src: W: spelling-error Summary(en_US) libpurple -> lib purple,
lib-purple, purple
purple-line.src: W: summary-not-capitalized C libpurple (Pidgin, Finch)
protocol plugin for LINE
purple-line.src: W: invalid-url Source0: purple-line-20150426git9b7b019.tar.gz
purple-line.x86_64: W: spelling-error Summary(en_US) libpurple -> lib purple,
lib-purple, purple
purple-line.x86_64: W: summary-not-capitalized C libpurple (Pidgin, Finch)
protocol plugin for LINE
3 packages and 0 specfiles checked; 0 errors, 5 warnings.

==> Fix summary capitalization

2) Group tag is not mandatory now so can be removed

3) License is MIT and not BSD as per LICENSE text

4) CFLAGS are not honored when compilation happens. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

5) Maybe you want to use %license macro as
%license LICENSE
%doc README.md

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]