Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: conduit - A synchronization solution for GNOME https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239236 ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2007-05-29 18:35 EST ------- (In reply to comment #14) > (In reply to comment #12) > > %if 0%{?fedora} && "%fedora" < "7" > > Requires: python-elementtree > > %endif > > I'm not sure if this is the best way to do it. > > I think you may want to consider building your cases around the dist macro in > the buildsystem. Can you explain further how this is better handled by dist macros? Are you talking about using something like: %{?fc6: Requires: python-elementtree} > Or you can forgo the use of if statements altogether if you are willing to > maintain different specfiles for different branches. You can first submit the > necessary specfile that works for F-7 and development without the elementree > requires and making sure the python requirement is versioned such that python >= > 2.5. When at all possible, I'd rather maintain the same spec file across multiple branches, especially when those changes are small and can be easy conditionalized. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review