https://bugzilla.redhat.com/show_bug.cgi?id=1234605 Ratnadeep Debnath <rtnpro@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(rtnpro@xxxxxxxxx) |needinfo?(rbean@xxxxxxxxxx) --- Comment #3 from Ratnadeep Debnath <rtnpro@xxxxxxxxx> --- Hey Ralph, >[!]: Three files/dirs problems I noticed: > - statscache-common should probably own the directory > %{python_sitelib}/%{modname}/ > - statscache-web should probably own the directory > %{_datadir}/%{modname}/ > - Lastly, I don't think %{_sysconfdir}/fedmsg.d/ should be declared in the > '%files common' section. The core fedmsg package already owns that > directory. Do you think it's a good idea to change the owner for %{python_sitelib}/%{modname} and for %{_datadir}/%{modname}. rpmlint on the RPMs throws warnings like: - non-standard uid - non-standard gid for both the lib and data dirs. What I see here: http://pkgs.fedoraproject.org/cgit/fedmsg.git/tree/fedmsg.spec is that you have changed owners for log/ and run/ dirs only. %attr(755, %{modname}, %{modname}) %dir %{_var}/log/%{modname} %attr(775, %{modname}, %{modname}) %dir %{_var}/run/%{modname} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review