https://bugzilla.redhat.com/show_bug.cgi?id=1237217 --- Comment #3 from Lubomir Rintel <lkundrak@xxxxx> --- * Named correctly * Packaged latest version * The commit matches the version tag * The license is fine for Fedora * Builds fine in mock A couple of remarks: 0.) The license tag looks incorrect I believe what's in COPYING is a MIT license. 1.) Are these really needed? > BuildRequires: erlang >= R14B ... > Requires: erlang Wouldn't it make more sense to just pull in the required modules instead of an entire stack? 2.) Please use %license tag instead o %doc for COPYING It makes the installation a bit more compact: https://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image 3.) Why you don't install the tools in %_bindir? How are they run? Btw if you choose to install them in %_bindir, note that gperf and ntop collide with existing tools -- you might need to rename them ("eper-gperf", ...). 4.) Please s/MacOs/MacOS X/ in %description -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review