[Bug 1235831] Review Request: vim-vcscommand - version control system commands from within vim

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1235831



--- Comment #3 from Marc Deop <marc@xxxxxxxxxxxx> ---
(In reply to Raphael Groner from comment #2)
> * Please remove Group: line, it's obsolete and not needed.

I plan on including this on EPEL as well, I think it is still useful on Red Hat
6.

> * Where do you have the sources zip from? Please provide an URL or at least
> comment in the spec file how you create it.

This was a mistake, I linked to the rpm instead of the src.prm:
http://marcdeop.fedorapeople.org/vim-vcscommand-1.99.47-1.fc21.src.rpm

> * Your description line is too long. Insert some line feeds to break it into
> several lines.

Shortened to less than 80 characters per line

> * Use 'cp -p' to preserve timestamps.

-a stands for archive which does already preserve the timestamps

> * Remove %doc, it is not necessary: %doc %{vimfiles_root}/doc/*

Why is this required?

> * Reference the complete individual folders: remove the star ('*') at the
> end of the %files lines but keep the trailing slashes ('/') at the pathes.

Fixed.

> 
> * The name of your linked SRPM file is wrong. Why is there no .srpm suffix?

Updating the links shortly

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]