[Bug 1236319] Review Request: python-lz4 - LZ4 Bindings for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1236319



--- Comment #14 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> ---
Thanks for the heads up Antoine. I see what you're doing is checking both the
version of python-lz4 and the version of lz4, assuming that the version of lz4
being used is the one bundled with python-lz4. Unfortunately that's going to
break for anyone (like us) using a system wide (not bundled) lz4 library. A
better approach would be to add a function to the python module which calls the
function in lz4 that returns the lz4 version number - I forget the name of the
function, but I spotted it yesterday when browsing the source. Anyway, I'll
knock up a patch to do that. 

I am planning to make some changes to setup.py too to allow the use of system
lz4 or bundled lz4 depending on what's available at build time, and it'll
adjust things accordingly. I hope upstream is receptive.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]