https://bugzilla.redhat.com/show_bug.cgi?id=1236319 Ville Skyttä <ville.skytta@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Ville Skyttä <ville.skytta@xxxxxx> --- Looks like this package bundles the entire lz4 source code instead of using the system lz4 libs, that needs to be addressed, either by adapting/patching to use the system libs, or by getting a bundling exception from FPC. Also, I'm not sure what the "Requires: lz4" is there for? Release should start with > 0 and stuff after %{?dist} should be dropped too as this is not a pre-release package. Non-blocker: As long as there's no test suite, something like this in %check would be better than nothing: PYTHONPATH=$RPM_BUILD_ROOT%{python2_sitearch} %{__python2} -c "import lz4" %if %{with python3} PYTHONPATH=$RPM_BUILD_ROOT%{python3_sitearch} %{__python3} -c "import lz4" %endif Non-blocker: the %if %{with python3} ... %endif wrapping around %package -n python3-lz4 and %description -n python3-lz4 can be dropped if you like (it doesn't do any harm in non-python3 builds). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review