https://bugzilla.redhat.com/show_bug.cgi?id=1230209 --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Test-Time.spec.old 2015-06-10 14:36:39.000000000 +0200 +++ perl-Test-Time.spec 2015-06-26 12:06:10.000000000 +0200 @@ -1,11 +1,18 @@ Name: perl-Test-Time Version: 0.04 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Overrides the time() and sleep() core functions for testing License: GPL+ or Artistic URL: http://search.cpan.org/dist/Test-Time/ Source0: http://www.cpan.org/authors/id/S/SA/SATOH/Test-Time-%{version}.tar.gz BuildArch: noarch + +BuildRequires: perl(inc::Module::Install) +BuildRequires: perl(Module::Install::AuthorTests) +BuildRequires: perl(Module::Install::Repository) +BuildRequires: perl(Module::Install::ReadmeFromPod) +BuildRequires: perl(Module::Install::TestBase) + BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(Filter::Util::Call) BuildRequires: perl(Test::More) @@ -21,7 +28,8 @@ %setup -q -n Test-Time-%{version} # Remove bundled modules -for f in inc/Spiffy.pm \ +for f in $(find inc/Module -name *.pm) \ + inc/Spiffy.pm \ inc/Test/Base/Filter.pm \ inc/Test/Name/FromLine.pm \ inc/Test/More.pm \ @@ -54,5 +62,8 @@ %{_mandir}/man3/* %changelog +* Fri Jun 26 2015 Ralf Corsépius <corsepiu@xxxxxxxxxxxxxxxxx> - 0.04-2 +- Remove bundled inc/Module. + * Mon Jun 08 2015 Ralf Corsépius <corsepiu@xxxxxxxxxxxxxxxxx> - 0.04-1 - Initial package. > TODO: Use plain `perl' command instead of %{__perl} macro and build-require > `perl'. Not addressed. Ok. > FIX: Remove all the bundled Module::Install files from ./inc, build-require > `perl(inc::Module::Install)' and other needed modules from Module::Install > namespace (locate functions called from Makefile.PL). Or declare all > build-time dependencies for the bundled Module::Install modules. +BuildRequires: perl(inc::Module::Install) +BuildRequires: perl(Module::Install::AuthorTests) +BuildRequires: perl(Module::Install::Repository) +BuildRequires: perl(Module::Install::ReadmeFromPod) +BuildRequires: perl(Module::Install::TestBase) That's fine, but not enough. Even upstream don't know what dependencies needs. Please also: FIX: Build-require `perl(Module::Install::Metadata)' (Makefile.PL:24). FIX: BUild-require `perl(Module::Install::Include)' (Makefile.PL:43). > FIX: Build-require `coreutils' (perl-Test-Time.spec:32). > FIX: Build-require `sed' (perl-Test-Time.spec:33). > FIX: Build-require `make' (perl-Test-Time.spec:38). > FIX: Build-require `findutils' (perl-Test-Time.spec:43). > FIX: Build-require `perl(strict)' (lib/Test/Time.pm:2). > FIX: Build-require `perl(warnings)' (lib/Test/Time.pm:3). FIX: Please add these dependencies. > TODO: Replace PERL_INSTALL_ROOT with DESTDIR argument in %install section. Not addressed. Ok. > TODO: Remove the unnecessary find command deleting empty directories from > %install section. Not addresses. Ok. Please correct all `FIX' items and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review