[Bug 1235305] Review Request: hitch - Network proxy that terminates TLS/SSL connections

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1235305



--- Comment #5 from Ingvar Hagelund <ingvar@xxxxxxxxx> ---
I updated the package again:

* Wed Jun 10 2015 Ingvar Hagelund <ingvar@xxxxxxxxxxxxxxxxxx> 1.0.0-0.3.beta3
- Added _hardened_build macro and PIE on el6

http://users.linpro.no/ingvar/varnish/hitch/hitch.spec
http://users.linpro.no/ingvar/varnish/hitch/hitch-1.0.0-0.3.2.beta3.fc22.src.rpm

(In reply to Sören Möller from comment #4)
> - I am unsure about the best name for the manpage. I interprete 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages as if it should
> be called "hitch-openssl", but I am far from sure.

I'l let this rest for now.

> - I am unsure how to chekck if "%build honors applicable compiler flags or
> justifies otherwise.", although I think it does as it does what I expected
> in build.log and no obvious changes in the spec-file

This means that the build will honor changes in the build environment, like
changing the CFLAGS and LDFLAGS variables before calling configure/make. It
does.

> - I did not evaluate the proper function of the package (but this is a
> SHOULD not a MUST, so I don't think this is a problem)

To test hitch, for example in front of varnish, in front of apache, do

- Install varnish, httpd and hitch
- Start apache (systemctl start httpd.service)
- Edit the varnish config to point to the local httpd
  That is, change the default backend definition in 
  /etc/varnish/default.vcl , like this:

  backend default {
    .host = "127.0.0.1";
    .port = "80";
  }

- Start varnish (systemctl start varnish.service)
- Add an ssl certificate to the hitch config. For a dummy certificate,
  the one in the hitch source may be used:

  sudo cp ~/rpmbuild/BUILD/hitch-*/tests/certs/default.example.com \
          /etc/pki/tls/private/default.example.com.pem

  Edit /etc/hitch/hitch.conf. Change the pem-file option to use that cert

  pem-file = "/etc/pki/tls/private/default.example.com.pem"

- Start hitch (systemctl start hitch.service)

Point your net browser to https://localhost:8443/ . You should be greeted with
a warning about a non-official certificate. Past that, you will get the apache
frontpage through varnish and hitch.

> - I was not able to run the tests as I get a lot of errors of this form:
> "warning: user ingvar does not exist - using root"
> "warning: group ingvar does not exist - using root"

These messages are not related to the tests. It is just that the user that
generated the source package ("ingvar") does not exist on your machine. This is
perfectly normal, and may safely be ignored.

> But I tried to run it with buildroot, as I didn't want to install it on the
> system, so it might work in that case.

As stated in a previous comment, %check is not enabled by default, as it won't
work on the koji builders, nor on machines that can't reach the Internet. You
can run the test suite without installing the package while building:

 rpmbuild --define "runcheck 1" -bb hitch.spec
 rpmbuild --define "runcheck 1" --rebuild hitch-1.0.0-0.3.2.beta3.fc22.src.rpm


Ingvar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]