Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: transset - Simple program to toggle Translucency property https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235555 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-05-28 21:01 EST ------- Just a quick glance (well, no so quick in fact) - minor problem: there are lots of duplicate BR: xorg-x11-proto-devel (by libX11-devel), pkgconfig (by libX11-devel), libX11-devel (by libXrender-devel), libXfixes-devel (by libXcomposite-devel) - the build log shows that compiler flags are not taken into account: + /usr/bin/make cc `pkg-config --cflags xcomposite xfixes xdamage xrender` -c transSet.c cc `pkg-config --cflags xcomposite xfixes xdamage xrender` -c dsimple.c cc -o transset transSet.o dsimple.o `pkg-config --libs xcomposite xfixes xdamage xrender` -lm + exit 0 - is the application a GUI ? If so, it should have a desktop file - I've tried to use it, but since there is no documentation, no man pages, nothing... I could not. Or maybe I could, but I did not know that until I read the sources. Whatever argument I pass to the application, it just echoes it and then sits until Ctrl-C is pressed: [wolfy@wolfy64 tmp]$ ./transset 1 got arg 1 d is 1 [wolfy@wolfy64 tmp]$ ./transset 12 got arg 12 d is 12 As upstream does not provide docs, I suggest creating a Readme.fedora file and include in it the comment from the beginning of transSet.c. Or add the first line of that comment to %Description. Just waiting for a mouse click without any useful output was not helpful and I doubt that users will have the patience to read the source code as I did. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review