https://bugzilla.redhat.com/show_bug.cgi?id=1225229 --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: ok 7f2425887d7bc8e86b53846f400d4ace light-locker-1.6.0.tar.bz2 1. licensing: NOT ok using licensecheck, it's clear all sources are GPLv2, so MUST use: License: GPLv2+ 2. scriptlets NOT ok, MUST add gsettings schema scriplets, see https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema 3. SHOULD drop desktop-file-validate %{buildroot}%{_sysconfdir}/xdg/autostart/*.desktop no need to validate autostart, only stuff under /usr/share/applications/ 4. MUST do verbose build (to show compiler flags), either use %configure --disable-silent-rules and/or make ... V=1 As a practical matter, it worries my a little that it seems to conditionally autostart based on DE used (regardless if lightdm is active or not?). this feels wrong to me, but I don't have any suggestions on how to improve that offhand. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review