[Bug 1230274] Review Request: mpssh - Parallel ssh tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1230274



--- Comment #2 from Ingvar Hagelund <ingvar@xxxxxxxxx> ---
Jeff wrote:
> * Please use the license file provided, ./debian/copyright, instead of 
>   extracting from the code.

Fixed

> * Please mark the license file with the %license macro instead of %doc.

Fixed

> * Source URL does not comply with guidelines:

Fixed 

> * Please provide Koji scratch builds for all supported releases (i.e. F21, F22, Rawhide)

Scratch builds:

rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10197639
f23:     http://koji.fedoraproject.org/koji/taskinfo?taskID=10197647
f22:     http://koji.fedoraproject.org/koji/taskinfo?taskID=10197657
f21:     http://koji.fedoraproject.org/koji/taskinfo?taskID=10197665
epel7:   http://koji.fedoraproject.org/koji/taskinfo?taskID=10197672
epel6:   http://koji.fedoraproject.org/koji/taskinfo?taskID=10197675
epel5:   http://koji.fedoraproject.org/koji/taskinfo?taskID=10197561

> * Build ignores compiler flags. The Makefile overrides CFLAGS and LDFLAGS.

Patched the Makefile, so it does not set LDFLAGS, and sets CFLAGS like this.

CFLAGS += -Wall -DSSHPATH=\"$(SSHPATH)\" -DSCPPATH=\"$(SCPPATH)\"

Is this good enough?

> * Seems to work? I was unable to actually get it to execute remote commands...

Works, at least for me:

$ cat test_hosts
veierland
login

$ mpssh -f test_hosts -v "whoami; hostname -s" 
Reading hosts from : test_hosts
MPSSH - Mass Parallel Ssh Ver.1.3.3
(c)2005-2013 Nikolay Denev <ndenev@xxxxxxxxx>

  [*] read (2) hosts from the list
  [*] executing "whoami; hostname -s" as user "ingvar"
  [*] verbose mode enabled
  [*] spawning 2 parallel ssh sessions

ingvar@veierland -> ingvar
ingvar@veierland -> veierland
ingvar@    login -> ingvar
ingvar@    login -> login

  Done. 2 hosts processed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]