[Bug 1220779] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1220779



--- Comment #22 from Ding-Yi Chen <dchen@xxxxxxxxxx> ---

Spec URL: https://dchen.fedorapeople.org/files/rpms/7kaa.spec
SRPM URL: https://dchen.fedorapeople.org/files/rpms/7kaa-2.14.5-7.fc22.src.rpm

> Issues:
> =======
> - Package installs properly.
>   Note: Installation errors (see attachment)
>   See: https://fedoraproject.org/wiki/Packaging:Guidelines
This is addressed.

> - If (and only if) the source package includes the text of the license(s)
>   in its own file, then that file, containing the text of the license(s)
>   for the package is included in %license.
>   Note: License file COPYING is marked as %doc instead of %license
>   See:
>   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

In spec now:
License:  GPLv3+ and GPLv2+ 

> Rpmlint
> -------
> Checking: 7kaa-2.14.5-6.fc23.x86_64.rpm
>           7kaa-data-2.14.5-6.fc23.noarch.rpm
>           7kaa-music-2.14.5-6.fc23.noarch.rpm
>           7kaa-2.14.5-6.fc23.src.rpm
> 7kaa-data.noarch: W: desktopfile-without-binary
> /usr/share/applications/7kaa.desktop 7kaa
> => Error. Please fix.

Fixed.

> 7kaa-music.noarch: W: dangerous-command-in-%postun rm
> => Please check.

After they run 7kaa-data-downloader, there will be music files.
This is actually for removing those music file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]