[Bug 1222227] Review Request: breathe - Doxygen xml output to reStructuredText

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1222227



--- Comment #2 from Dave Johansen <davejohansen@xxxxxxxxx> ---
The updated .spec file and source .rpm are available at the previously listed
URLs (the originals are at *_v1). The details of the fixes are listed below.

> I'd strongly suggest adding %global _docdir_fmt %{name}. Then a single directory docs and license directories will be used (/usr/share/doc/breathe-doc should simply be /usr/share/doc/breathe).
Fixed

> [!]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses
>      found: "Unknown or generated", "zlib/libpng". 104 files have unknown
>      license. Detailed output of licensecheck in
>      /var/tmp/1222227-breathe/licensecheck.txt
> [!]: License file installed when any subpackage combination is installed.
> No license file (or dependency on main package) in breathe-doc.
> [-]: If the source package does not include license text(s) as a separate
>      file from upstream, the packager SHOULD query upstream to include it.
Sorry. I had forgotten to package the license file, but that's now fixed.

> [-]: %check is present and all tests pass.
Upstream has no tests in 4.0.0 release

> Rpmlint
> -------
> breathe.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/breathe/parser/doxygen/compound.py 0644L /usr/bin/env
> breathe.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/breathe/parser/doxygen/index.py 0644L /usr/bin/env
> breathe.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/breathe/parser/doxygen/compoundsuper.py 0644L /usr/bin/env
> breathe.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/breathe/parser/doxygen/indexsuper.py 0644L /usr/bin/env
Added patch to fix this and submitted it upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]