https://bugzilla.redhat.com/show_bug.cgi?id=1234654 Sergio Monteiro Basto <sergio@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #1 from Sergio Monteiro Basto <sergio@xxxxxxxxxx> --- Hi Sergio Sérgio Basto schrieb am Di., 23. Juni 2015 um 02:07 Uhr: Hi, I saw you in https://admin.fedoraproject.org/pkgdb/package/gammu/ Do want/help review this package [1] ? I'll see if I find the time as I am currently very busy. Sorry. - Why don't you have a python3 subpackage? It seems to be supported: https://pypi.python.org/pypi/python-gammu/ - What does the Obsoletes mean? It's a new package, you don't need to obsolete python-gammu < some old version. - Please call the setup.py with the proper python macro. - As the tests are included in the tarball [2], could you try to %check them when building? - The group seems strange, I'd remove it as iirc it is not needed anymore. The rest seems fine on the first brief look. Best, Tom [1] https://bugzilla.redhat.com/show_bug.cgi?id=1234654 [2] https://github.com/gammu/python-gammu/blob/master/MANIFEST.in -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review