https://bugzilla.redhat.com/show_bug.cgi?id=1234468 --- Comment #5 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Hi, (In reply to gil cattaneo from comment #4) > Issues: > - If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file COPYING is marked as %doc instead of %license > See: > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text > FIXME > - Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 1105920 bytes in 181 files. > See: > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation > FIXME > [!]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %define gitdate 20150622 > FIXME Thanks for the quick and thorough review, all fixed, new version here: Spec URL: https://fedorapeople.org/~jwrdegoede/envytools.spec SRPM URL: https://fedorapeople.org/~jwrdegoede/envytools-0.0-0.2.git20150622.fc22.src.rpm I'll go and review your package now. Regards, Hans -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review