https://bugzilla.redhat.com/show_bug.cgi?id=1234468 --- Comment #3 from gil cattaneo <puntogil@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text FIXME - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1105920 bytes in 181 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation FIXME ===== MUST items ===== C/C++: [?]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 40 files have unknown license. Detailed output of licensecheck in /home/gil/1234468-envytools/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define gitdate 20150622 [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [?]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2478080 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: envytools-0.0-0.1.git20150622.fc23.i686.rpm envytools-0.0-0.1.git20150622.fc23.src.rpm envytools.i686: W: spelling-error Summary(en_US) nvidia's -> Diana's envytools.i686: W: spelling-error %description -l en_US nouveau -> Noumea envytools.i686: W: spelling-error %description -l en_US Disassembler -> Dis assembler, Dis-assembler, Disassemble envytools.i686: W: spelling-error %description -l en_US nvidia -> Dravidian envytools.i686: W: spelling-error %description -l en_US nva -> nova, van, ova envytools.i686: W: spelling-error %description -l en_US vstream -> stream, v stream envytools.i686: W: spelling-error %description -l en_US bitstreams -> bit streams, bit-streams, streams envytools.i686: W: no-manual-page-for-binary nvaevo envytools.i686: W: no-manual-page-for-binary nvacounter envytools.i686: W: no-manual-page-for-binary nvatiming envytools.i686: W: no-manual-page-for-binary nvaxtpoke envytools.i686: W: no-manual-page-for-binary nvaforcetemp envytools.i686: W: no-manual-page-for-binary nvafill envytools.i686: W: no-manual-page-for-binary deh262 envytools.i686: W: no-manual-page-for-binary deh261 envytools.i686: W: no-manual-page-for-binary deh264 envytools.i686: W: no-manual-page-for-binary nvawatch envytools.i686: W: no-manual-page-for-binary nvapeek envytools.i686: W: no-manual-page-for-binary demmt envytools.i686: W: no-manual-page-for-binary nvaxtstart envytools.i686: W: no-manual-page-for-binary evotiming envytools.i686: W: no-manual-page-for-binary nvapoke envytools.i686: W: no-manual-page-for-binary envyas envytools.i686: W: no-manual-page-for-binary nv01post envytools.i686: W: no-manual-page-for-binary nvamemtiming envytools.i686: W: no-manual-page-for-binary nvaxtpeek envytools.i686: W: no-manual-page-for-binary nvapms envytools.i686: W: no-manual-page-for-binary nvapeeki envytools.i686: W: no-manual-page-for-binary nvalist envytools.i686: W: no-manual-page-for-binary mmt_ufw envytools.i686: W: no-manual-page-for-binary nvafuzz envytools.i686: W: no-manual-page-for-binary nvagetpmu envytools.i686: W: no-manual-page-for-binary envydis envytools.i686: W: no-manual-page-for-binary nvafakebios envytools.i686: W: no-manual-page-for-binary nvammiotracereplay envytools.i686: W: no-manual-page-for-binary nvagetbios envytools.i686: W: no-manual-page-for-binary dumpstruct envytools.i686: W: no-manual-page-for-binary nvaxtinsn envytools.i686: W: no-manual-page-for-binary nvaupload envytools.i686: W: no-manual-page-for-binary nvaxttime envytools.i686: W: no-manual-page-for-binary nvapeekstat envytools.i686: W: no-manual-page-for-binary nvastrscan envytools.i686: W: no-manual-page-for-binary nv01dump envytools.i686: W: no-manual-page-for-binary nvavucstart envytools.i686: W: no-manual-page-for-binary vdpow envytools.i686: W: no-manual-page-for-binary nvaspyi2c envytools.i686: W: no-manual-page-for-binary nvadownload envytools.i686: W: no-manual-page-for-binary mmt_bin2dedma envytools.i686: W: no-manual-page-for-binary nvaxtssr envytools.i686: W: no-manual-page-for-binary nvascan envytools.i686: W: no-manual-page-for-binary nvahammer envytools.i686: W: no-manual-page-for-binary nvafucstart envytools.i686: W: no-manual-page-for-binary nvaxtrsr envytools.i686: W: no-manual-page-for-binary nvbios envytools.src: W: spelling-error Summary(en_US) nvidia's -> Diana's envytools.src: W: spelling-error %description -l en_US nouveau -> Noumea envytools.src: W: spelling-error %description -l en_US envydis -> envy dis, envy-dis, envying envytools.src: W: spelling-error %description -l en_US Disassembler -> Dis assembler, Dis-assembler, Disassemble envytools.src: W: spelling-error %description -l en_US nvidia -> Dravidian envytools.src: W: spelling-error %description -l en_US nvbios -> BIOS envytools.src: W: spelling-error %description -l en_US nva -> nova, van, ova envytools.src: W: spelling-error %description -l en_US vstream -> stream, v stream envytools.src: W: spelling-error %description -l en_US bitstreams -> bit streams, bit-streams, streams envytools.src: W: strange-permission make-git-snapshot.sh 0775L envytools.src: W: invalid-url Source0: envytools-20150622.tar.bz2 2 packages and 0 specfiles checked; 0 errors, 65 warnings. Rpmlint (debuginfo) ------------------- Checking: envytools-debuginfo-0.0-0.1.git20150622.fc23.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- envytools.i686: W: spelling-error Summary(en_US) nvidia's -> Dravidian's envytools.i686: W: spelling-error %description -l en_US nouveau -> Noumea envytools.i686: W: spelling-error %description -l en_US Disassembler -> Dis assembler, Dis-assembler, Disassemble envytools.i686: W: spelling-error %description -l en_US nvidia -> Dravidian envytools.i686: W: spelling-error %description -l en_US nva -> nova, van, ova envytools.i686: W: spelling-error %description -l en_US vstream -> stream, v stream envytools.i686: W: spelling-error %description -l en_US bitstreams -> bit streams, bit-streams, streams envytools.i686: W: no-manual-page-for-binary nvaevo envytools.i686: W: no-manual-page-for-binary nvacounter envytools.i686: W: no-manual-page-for-binary nvatiming envytools.i686: W: no-manual-page-for-binary nvaxtpoke envytools.i686: W: no-manual-page-for-binary nvaforcetemp envytools.i686: W: no-manual-page-for-binary nvafill envytools.i686: W: no-manual-page-for-binary deh262 envytools.i686: W: no-manual-page-for-binary deh261 envytools.i686: W: no-manual-page-for-binary deh264 envytools.i686: W: no-manual-page-for-binary nvawatch envytools.i686: W: no-manual-page-for-binary nvapeek envytools.i686: W: no-manual-page-for-binary demmt envytools.i686: W: no-manual-page-for-binary nvaxtstart envytools.i686: W: no-manual-page-for-binary evotiming envytools.i686: W: no-manual-page-for-binary nvapoke envytools.i686: W: no-manual-page-for-binary envyas envytools.i686: W: no-manual-page-for-binary nv01post envytools.i686: W: no-manual-page-for-binary nvamemtiming envytools.i686: W: no-manual-page-for-binary nvaxtpeek envytools.i686: W: no-manual-page-for-binary nvapms envytools.i686: W: no-manual-page-for-binary nvapeeki envytools.i686: W: no-manual-page-for-binary nvalist envytools.i686: W: no-manual-page-for-binary mmt_ufw envytools.i686: W: no-manual-page-for-binary nvafuzz envytools.i686: W: no-manual-page-for-binary nvagetpmu envytools.i686: W: no-manual-page-for-binary envydis envytools.i686: W: no-manual-page-for-binary nvafakebios envytools.i686: W: no-manual-page-for-binary nvammiotracereplay envytools.i686: W: no-manual-page-for-binary nvagetbios envytools.i686: W: no-manual-page-for-binary dumpstruct envytools.i686: W: no-manual-page-for-binary nvaxtinsn envytools.i686: W: no-manual-page-for-binary nvaupload envytools.i686: W: no-manual-page-for-binary nvaxttime envytools.i686: W: no-manual-page-for-binary nvapeekstat envytools.i686: W: no-manual-page-for-binary nvastrscan envytools.i686: W: no-manual-page-for-binary nv01dump envytools.i686: W: no-manual-page-for-binary nvavucstart envytools.i686: W: no-manual-page-for-binary vdpow envytools.i686: W: no-manual-page-for-binary nvaspyi2c envytools.i686: W: no-manual-page-for-binary nvadownload envytools.i686: W: no-manual-page-for-binary mmt_bin2dedma envytools.i686: W: no-manual-page-for-binary nvaxtssr envytools.i686: W: no-manual-page-for-binary nvascan envytools.i686: W: no-manual-page-for-binary nvahammer envytools.i686: W: no-manual-page-for-binary nvafucstart envytools.i686: W: no-manual-page-for-binary nvaxtrsr envytools.i686: W: no-manual-page-for-binary nvbios 2 packages and 0 specfiles checked; 0 errors, 54 warnings. Requires -------- envytools (rpmlib, GLIBC filtered): libX11.so.6 libXext.so.6 libc.so.6 libpciaccess.so.0 libpthread.so.0 librt.so.1 libseccomp.so.2 libvdpau.so.1 libxml2.so.2 libxml2.so.2(LIBXML2_2.4.30) rtld(GNU_HASH) Provides -------- envytools: envytools envytools(x86-32) Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1234468 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review