[Bug 1225073] Review Request: perl-MouseX-NativeTraits - Extend your attribute interfaces for Mouse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1225073

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Spec file changes:

$ diff -u perl-MouseX-NativeTraits.spec{.old,}
--- perl-MouseX-NativeTraits.spec.old   2015-05-26 15:55:25.000000000 +0200
+++ perl-MouseX-NativeTraits.spec       2015-06-22 14:47:16.000000000 +0200
@@ -8,6 +8,10 @@
 Source0:       
http://www.cpan.org/authors/id/G/GF/GFUJI/MouseX-NativeTraits-%{version}.tar.gz
 Patch0:         MouseX-NativeTraits-1.09-Disable-author-tests.patch
 BuildArch:      noarch
+BuildRequires:  coreutils
+BuildRequires:  findutils
+BuildRequires:  make
+BuildRequires:  sed
 BuildRequires:  perl
 BuildRequires:  perl(Any::Moose) >= 0.13
 BuildRequires:  perl(Data::Dumper)
@@ -26,7 +30,6 @@
 BuildRequires:  perl(Test::More) >= 0.88
 BuildRequires:  perl(Test::Mouse)
 BuildRequires:  perl(Tie::Hash)
-BuildRequires:  perl(vars)
 BuildRequires:  perl(warnings)
 Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
 Requires:       perl(Mouse) >= 0.82


> TODO: Do not build-require `perl(vars)'. It's only required from bundled
> ./inc which is not used.
-BuildRequires:  perl(vars)
Ok.

> FIX: Build-require coreutils (perl-MouseX-NativeTraits.spec:44).
+BuildRequires:  coreutils
Ok.

> FIX: Build-require sed (perl-MouseX-NativeTraits.spec:45).
+BuildRequires:  sed
Ok.

> FIX: Build-require findutils (perl-MouseX-NativeTraits.spec:46).
+BuildRequires:  findutils
Ok.

> FIX: Build-require make (perl-MouseX-NativeTraits.spec:50).
+BuildRequires:  make
Ok.

$ rpmlint perl-MouseX-NativeTraits.spec
../SRPMS/perl-MouseX-NativeTraits-1.09-1.fc23.src.rpm
../RPMS/noarch/perl-MouseX-NativeTraits-1.09-1.fc23.noarch.rpm 
perl-MouseX-NativeTraits.src: W: spelling-error %description -l en_US accessors
-> accessory, accessorizes, accessorize
perl-MouseX-NativeTraits.src: W: spelling-error %description -l en_US clearers
-> clearer, cleaners, cleavers
perl-MouseX-NativeTraits.noarch: W: spelling-error %description -l en_US
accessors -> accessory, accessorizes, accessorize
perl-MouseX-NativeTraits.noarch: W: spelling-error %description -l en_US
clearers -> clearer, cleaners, cleavers
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.

Package builds in F23
(http://koji.fedoraproject.org/koji/taskinfo?taskID=10177354). Ok.

Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]