[Bug 1228230] Review Request: python-oauth2client - Python client library for OAuth 2.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1228230



--- Comment #2 from Michele Baldessari <michele@xxxxxxxxxx> ---
(In reply to Julien Enselme from comment #1)
> - Please remove the fonts from the doc package
ACK

> - Please use python versionned macros (%{python2_sitelib} and %{__python2}):
> https://fedoraproject.org/wiki/Packaging:Python#Macros
ACK

> - gflags is not a dependency since 1.2. It must be removed from Requires.
> See:
> https://github.com/google/oauth2client/blob/
> c815c2babd6ed811ba426e014f03978d48f59d9c/CHANGELOG.md

This is still needed for my dependent package (gcalcli) because it is still
using the (deprecated) API oauth2client.tools.run()

> - You may fetch the tarball from pypi:
> https://pypi.python.org/pypi/oauth2client/

I kind of prefer github as most of my packages live there, but
I can change it if you deem it necessary

> - You forgot the -O1 flag for python 3 (it is there for python 2)
ACK

Julien, thanks again for all the feedback.

Here are the new packages:
Spec URL:
http://acksyn.org/files/rpms/python-oauth2client/python-oauth2client.spec
SRPM URL:
http://acksyn.org/files/rpms/python-oauth2client/python-oauth2client-1.4.11-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]