https://bugzilla.redhat.com/show_bug.cgi?id=1230209 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: d8c1bc57f9767ae8122fc4ab873bd991cb9ea8e9422c66399acb66770fa5c2ea). Ok. Summary verified from lib/Test/Time.pm. Ok. Description verified from lib/Test/Time.pm. Ok. License verified from README and lib/Test/Time.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: Use plain `perl' command instead of %{__perl} macro and build-require `perl'. FIX: Remove all the bundled Module::Install files from ./inc, build-require `perl(inc::Module::Install)' and other needed modules from Module::Install namespace (locate functions called from Makefile.PL). Or declare all build-time dependencies for the bundled Module::Install modules. FIX: Build-require `coreutils' (perl-Test-Time.spec:32). FIX: Build-require `sed' (perl-Test-Time.spec:33). FIX: Build-require `make' (perl-Test-Time.spec:38). FIX: Build-require `findutils' (perl-Test-Time.spec:43). FIX: Build-require `perl(strict)' (lib/Test/Time.pm:2). FIX: Build-require `perl(warnings)' (lib/Test/Time.pm:3). TODO: Replace PERL_INSTALL_ROOT with DESTDIR argument in %install section. TODO: Remove the unnecessary find command deleting empty directories from %install section. All tests pass. Ok. $ rpmlint perl-Test-Time.spec ../SRPMS/perl-Test-Time-0.04-1.fc23.src.rpm ../RPMS/noarch/perl-Test-Time-0.04-1.fc23.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package builds in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=10164235). Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Test-Time-0.04-1.fc23.noarch.rpm drwxr-xr-x 2 root root 0 Jun 19 11:16 /usr/share/doc/perl-Test-Time -rw-r--r-- 1 root root 253 Jun 14 2012 /usr/share/doc/perl-Test-Time/Changes -rw-r--r-- 1 root root 943 Jun 14 2012 /usr/share/doc/perl-Test-Time/README -rw-r--r-- 1 root root 1575 Jun 19 11:16 /usr/share/man/man3/Test::Time.3pm.gz drwxr-xr-x 2 root root 0 Jun 19 11:16 /usr/share/perl5/vendor_perl/Test -rw-r--r-- 1 root root 1537 Jun 14 2012 /usr/share/perl5/vendor_perl/Test/Time.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Test-Time-0.04-1.fc23.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(strict) 1 perl(Test::More) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Test-Time-0.04-1.fc23.noarch.rpm | sort -f | uniq -c 1 perl(Test::Time) = 0.04 1 perl-Test-Time = 0.04-1.fc23 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Test-Time-0.04-1.fc23.noarch.rpm Binary dependencies resolvable. Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review