https://bugzilla.redhat.com/show_bug.cgi?id=1231953 --- Comment #3 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > Issues: > ======= > - Package does not contain duplicates in %files. > Note: warning: File listed twice: /usr/share/java/querydsl3 > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles Fixed > - License is wrong, should be ASLv2. Fixed > [ ]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > querydsl3-apt , querydsl3-codegen , querydsl3-collections , querydsl3 > -hibernate-search , querydsl3-jdo , querydsl3-jpa , querydsl3-jpa- > codegen , querydsl3-lucene3 , querydsl3-maven-plugin , > querydsl3-mongodb , querydsl3-root , querydsl3-scala , > querydsl3-spatial , querydsl3-sql , querydsl3-sql-codegen , querydsl3 > -sql-spring , querydsl3-javadoc > I guess that's OK, because an automatically generated dependency of the form > mvn(com.mysema.querydsl:querydsl-core) = 3.6.4 > is present. Is "ok" because this is a noarch package. it would not make sense to use this "signature". (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > Linewrap %description at 72 chars. > > "type safety" not "type-safety" according to wikipedia. is "type-safe" where is "type-safety" ? > What is "apt" Annotation Processing Tool http://docs.oracle.com/javase/7/docs/technotes/guides/apt/ "jdo", Java Data Objects http://www.oracle.com/technetwork/java/index-jsp-135919.html "jpa"? Java Persistence API http://www.oracle.com/technetwork/java/javaee/tech/persistence-jsp-140049.html > Looks good, I'm running fedora-review now. Thanks! Spec URL: https://gil.fedorapeople.org/querydsl3.spec SRPM URL: https://gil.fedorapeople.org/querydsl3-3.6.4-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review