Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Net-IPv6Addr - Perl module to check validity of IPv6 addresses Alias: perl-Net-IPv6Addr https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239163 ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2007-05-27 17:55 EST ------- "Artistic or GPL" should be "GPL or Artistic". Missing BRs on: perl(Math::Base85) perl(ExtUtils::MakeMaker) Package should have an explicit "Requires: perl(Math::Base85)" as the dep is not being picked up automagically. There are a number of rfc docs included. Why not add these to %doc? Make the above changes, and I'll approve. :) + source files match upstream: cd06f0422ddb3ac119e2ef1e27aa9339 Net-IPv6Addr-0.2.tar.gz cd06f0422ddb3ac119e2ef1e27aa9339 Net-IPv6Addr-0.2.tar.gz.srpm + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text not included upstream. + latest version is being packaged. X BuildRequires are proper. + compiler flags are appropriate (noarch) + %clean is present. + package installs properly + rpmlint is silent. X final provides and requires are sane: ** perl-Net-IPv6Addr-0.2-1.fc6.noarch.rpm == rpmlint == provides perl(Net::IPv6Addr) = 0.2 perl-Net-IPv6Addr = 0.2-1.fc6 == requires perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Net::IPv4Addr) perl(strict) perl(vars) + %check is present and all tests pass: All tests successful. Files=9, Tests=287, 1 wallclock secs ( 0.70 cusr + 0.20 csys = 0.90 CPU) + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review