[Bug 1231863] Review Request: bcm283x-firmware - Broadcom bcm283x firmware for the Raspberry Pi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1231863

Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #1 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> ---
Minor items:

* the license tag must be:

"License: Redistributable, no modification permitted"

You've got a comment tacked on to the end, change it to look like this:

# see LICENSE.broadcom
License: Redistributable, no modification permitted

* Add a period at the end of the %description text.

* Change the URL to the github link, that's way more accurate.

Everything else looks clean here. There is no compilation, just file copying,
and the source is correct. Make those changes, show me the fixed spec, and I'll
approve.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]