[Bug 1220779] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1220779



--- Comment #16 from Ding-Yi Chen <dchen@xxxxxxxxxx> ---
(In reply to Raphael Groner from comment #14)
> licensecheck.txt:
> 
> GPL (v2 or later)
> -----------------
> …
> 
> GPL (v3 or later)
> -----------------
> /home/builder/fedora-review/1220779-7kaa/upstream-unpacked/Source0/7kaa-2.14.
> 5/include/gettext.h

It looks like upstream grab gettext.h from gettext-0.19.4 then modify from
there. See diff below. The others files looks like GPLv2.

I don't think upstream can change the license of gettext.h, how should I
address this problem?


=== Begin diff
19a20,71
> /* Disable gettext if compiling with MSVC.  */
> #ifdef _MSC_VER
> 
> #include <stdarg.h>
> #include <stdio.h>
> 
> /* c99_snprintf and c99_vsnprintf implementations taken from:
>      http://stackoverflow.com/a/8712996  */
> #define snprintf c99_snprintf
> 
> inline
> int
> c99_vsnprintf (char *str, size_t size, const char *format, va_list ap)
> {
>   int count = -1;
> 
>   if (size != 0)
>     count = _vsnprintf_s(str, size, _TRUNCATE, format, ap);
>   if (count == -1)
>     count = _vscprintf(format, ap);
> 
>   return count;
> }
> 
> inline
> int
> c99_snprintf (char *str, size_t size, const char *format, ...)
> {
>   int count;
>   va_list ap;
> 
>   va_start(ap, format);
>   count = c99_vsnprintf(str, size, format, ap);
>   va_end(ap);
> 
>   return count;
> }
> 
> # undef gettext
> # define gettext(Msgid) ((const char *) (Msgid))
> # undef ngettext
> # define ngettext(Msgid1, Msgid2, N) \
>     ((N) == 1 \
>      ? ((void) (Msgid2), (const char *) (Msgid1)) \
>      : ((void) (Msgid1), (const char *) (Msgid2)))
> # undef pgettext
> # define pgettext(Msgctxt, Msgid) ((const char *) (Msgid))
> # define _(String) gettext (String)
> # define N_(String) (String)
> 
> #else
> 
108a161,164
> /* Additional keywords.  */
> #define _(String) gettext (String)
> #define N_(String) gettext_noop (String)
> 
285a342,343
> 
> #endif /* _MSC_VER */
=== End diff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]