https://bugzilla.redhat.com/show_bug.cgi?id=1220779 --- Comment #12 from Raphael Groner <projects.rg@xxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in 7kaa See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [?]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 12 files have unknown license. Detailed output of licensecheck in /home/builder/fedora- review/1220779-7kaa/licensecheck.txt => At least, you have to use License: GPLv2+ and GPLv3+ => Please try to get clarification about those files "Unknown or generated". [?]: License file installed when any subpackage combination is installed. => No license file found. Please request upstream to include some valid license text: https://www.gnu.org/licenses/gpl.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/7kaa => Please fix. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/32x32/apps, /usr/share/7kaa, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor => You have to add Requires: hicolor-icon-theme [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. Note: Especially check following dirs for bundled code: /home/builder /fedora-review/1220779-7kaa/upstream- unpacked/Source0/7kaa-2.14.5/include [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in 7kaa- music [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. => use of autodownloader and specific installation [?]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define data_installer %{name }-data-installer, %define prj_music_dir %{_datadir}/%{name}/music [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 105103360 bytes in /usr/share 7kaa-2.14.5-4.fc23.x86_64.rpm:105103360 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: 7kaa-2.14.5-4.fc23.x86_64.rpm 7kaa-music-2.14.5-4.fc23.noarch.rpm 7kaa-2.14.5-4.fc23.src.rpm 7kaa.x86_64: W: no-manual-page-for-binary 7kaa 7kaa-music.noarch: W: no-documentation 7kaa-music.noarch: W: no-manual-page-for-binary 7kaa-data-installer 7kaa-music.noarch: W: dangerous-command-in-%postun rm 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: 7kaa-debuginfo-2.14.5-4.fc23.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Requires -------- 7kaa-music (rpmlib, GLIBC filtered): /bin/bash /bin/sh 7kaa autodownloader sudo 7kaa (rpmlib, GLIBC filtered): libSDL2-2.0.so.0()(64bit) libc.so.6()(64bit) libenet.so.7()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libopenal.so.1()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- 7kaa-music: 7kaa-music 7kaa: 7kaa 7kaa(x86-64) application() application(7kaa.desktop) Source checksums ---------------- http://sourceforge.net/projects/skfans/files/7kaa-2.14.5.tar.xz : CHECKSUM(SHA256) this package : c7f04fa640d324ed8f1523da49945acd0f1ee2a99e3ee82ee29b52d2f735e464 CHECKSUM(SHA256) upstream package : c7f04fa640d324ed8f1523da49945acd0f1ee2a99e3ee82ee29b52d2f735e464 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1220779 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review