https://bugzilla.redhat.com/show_bug.cgi?id=1125952 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #12 from Raphael Groner <projects.rg@xxxxxxxx> --- APPROVED. Unclear issues (SHOULD be fixed in official package): - Please document why there's the libs subpackage (for partly multilib prevention?). - Please ensure correct %{?_isa} at Requires of/for libs subpackage and kqtquickcharts. - Specific app icons take about ~2MB in total size. Maybe split into noarch subpackage. - Be aware of rpmlint warning gzipped-svg-icon. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed => OK, found no *.m4 files, https://fedorahosted.org/FedoraReview/ticket/53 [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. => OK, see previous discussion [x]: License file installed when any subpackage combination is installed. => libs subpackage requires main package and reversed [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. => kqtquickcharts is mentioned in documentation. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in artikulate [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 634880 bytes in 27 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in artikulate-libs => Note is maybe wrong, no %{?_isa} found: Requires: %{name} = %{version}-%{release} [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3031040 bytes in /usr/share => OK, mainly cause specific app icons for hicolor with their total size of ~2MB [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: artikulate-15.04.1-1.fc23.x86_64.rpm artikulate-libs-15.04.1-1.fc23.x86_64.rpm artikulate-15.04.1-1.fc23.src.rpm artikulate.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/apps/artikulate.svgz gzipped-svg-icon: Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. artikulate.x86_64: W: no-manual-page-for-binary artikulate artikulate-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment artikulate-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment artikulate-libs.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (debuginfo) ------------------- Checking: artikulate-debuginfo-15.04.1-1.fc23.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Requires -------- artikulate-libs (rpmlib, GLIBC filtered): /sbin/ldconfig artikulate libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtDeclarative.so.4()(64bit) libQtGLib-2.0.so.0()(64bit) libQtGStreamer-1.0.so.0()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSql.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libQtXmlPatterns.so.4()(64bit) libartikulatelearnerprofile.so.4()(64bit) libartikulatesound.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libkdeclarative.so.5()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkfile.so.4()(64bit) libkio.so.5()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) artikulate (rpmlib, GLIBC filtered): /bin/sh artikulate-libs(x86-64) kde-runtime kqtquickcharts(x86-64) libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtDeclarative.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libartikulatecore.so.4()(64bit) libartikulatelearnerprofile.so.4()(64bit) libartikulatesound.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libkdeclarative.so.5()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libknewstuff3.so.4()(64bit) libm.so.6()(64bit) libplasma.so.3()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- artikulate-libs: artikulate-libs artikulate-libs(x86-64) libartikulatecore.so.4()(64bit) libartikulatelearnerprofile.so.4()(64bit) libartikulatesound.so.4()(64bit) artikulate: appdata() appdata(artikulate.appdata.xml) application() application(kde4/artikulate.desktop) artikulate artikulate(x86-64) Source checksums ---------------- http://download.kde.org/stable/applications/15.04.1/src/artikulate-15.04.1.tar.xz : CHECKSUM(SHA256) this package : ee451e233cc9f21089e04a0296e8326b2ee21373c82510f6d12671509b7d2891 CHECKSUM(SHA256) upstream package : ee451e233cc9f21089e04a0296e8326b2ee21373c82510f6d12671509b7d2891 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1125952 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review