[Bug 1230965] Review Request: php-doctrine-doctrine-cache-bundle - Symfony2 Bundle for Doctrine Cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1230965



--- Comment #3 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> ---
(In reply to Remi Collet from comment #1)
> Shouldn't your autoloader also manage dependency ?
> (ok, setUseIncludePath should allow this, but only as a fallback)

I haven't updated all packages to provide their own autoloader yet so I am
using the include path as a fallback for now and I will update when I can.



(In reply to Remi Collet from comment #2)
> I forget to ask, why don't you requires the dependencies from "requires" in
> composer.json ?
> 
>     "require": {
>         "php":                     ">=5.3.2",
>         "symfony/security":        "~2.2",
>         "symfony/doctrine-bridge": "~2.2",
>         "doctrine/inflector":      "~1.0",
>         "doctrine/cache":          "~1.3"

I just totally screwed up the dependencies! THANKS for catching that! Fixed.
Diff:
https://github.com/siwinski/rpms/commit/428617de6f7b50c4fb4f64a012edcf8103ad0bd6



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/428617de6f7b50c4fb4f64a012edcf8103ad0bd6/php-doctrine-doctrine-cache-bundle/php-doctrine-doctrine-cache-bundle.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-doctrine-doctrine-cache-bundle-1.0.1-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]