[Bug 1175023] Review Request: oggify - audio conversion tool for music library conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1175023



--- Comment #29 from Gerald Cox <gbcox@xxxxxx> ---
(In reply to Jerry James from comment #27)
> 
> $ rpm -q --requires -p oggify-2.0.7-4.fc23.noarch.rpm/usr/bin/python2
> flac
> python(abi) = 2.7
> rpmlib(CompressedFileNames) <= 3.0.4-1
> rpmlib(FileDigests) <= 4.6.0-1
> rpmlib(PartialHardlinkSets) <= 4.0.4-1
> rpmlib(PayloadFilesHavePrefix) <= 4.0-1
> rpmlib(PayloadIsXz) <= 5.2-1
> vorbis-tools
> 
> There is no mention of python-mutagen.  The rule is to examine the generated
> Requires after building and make sure everything your package needs is
> listed there.  If it is, then great: the dependency generator figured it out
> for you.  If not, then you have to list it manually in the spec file.

Yup, understood.  I've added. Thanks!

I've been thinking about an alternative to cloning and manually issuing the git
commands; then rebuilding and posting the new archive.  The workaround I've
come up with pulls the two archives (Oggify and tag_wrapper), changes their
permissions (rpmlint had an issue with the git defaults), then in %prep merge
the two archives.  This approach required me to add %commitx, %shortcommitx and
%checkout.

It will be in the next review candidate.  Thanks for your help in all this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]