https://bugzilla.redhat.com/show_bug.cgi?id=951496 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |graham_alton@xxxxxxxxxxx Flags| |needinfo?(graham_alton@hotm | |ail.com) --- Comment #18 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Naming: ok Sources: NOT ok 1. MUST: Source0 URL doesn't work, spectool -g *.spec Getting http://dl.bintray.com/content/seebk/GIMP-Lensfun/gimplensfun-0.2.3.tar.gz to ./gimplensfun-0.2.3.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (22) The requested URL returned error: 404 Not Found while we're at it, I'd encourage you to use the %{version} macro in the URL, instead of hard-coding 0.2.3 (to make future updates easier), so: Source0: https://github.com/seebk/GIMP-Lensfun/releases/download/%{version}/gimplensfun-%{version}.tar.gz confirmed that source has the same checksum, $ md5sum *.gz 2ac8cc61ab3672aa01311e47dfd911b0 gimplensfun-0.2.3.tar.gz 2. SHOULD document patches. Patch0: %{name}-remove-cci.patch What's the purpose of this patch? why is it needed? any bug references? 3. SHOULD omit deprecated rpm bits: Group:, BuildRoot:, %clean section, from %install: rm -rf $RPM_BUILD_ROOT 4. License: NOT ok. $ licensecheck * gimplensfun.cpp: GPL (v3 or later) LUT.hpp: GPL (v3 or later) MUST use License: GPLv3+ (unless you can clarify upstream intent to want only GPLv3, and and a .spec comment saying so) scriptlets: ok 5. dependencies: NOT ok These MUST be removed: Requires: lensfun Requires: exiv2 rpm should pull both of these library dependencies in via autorequires... unless does gimp-lensfun really need exiv2 (and not just the exiv2 library from exiv2-libs)? Fix these, and we should be close to approval. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review