https://bugzilla.redhat.com/show_bug.cgi?id=1231318 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #6 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- ===== MUST items ===== [!]: Requires correct, justified where necessary. see phpcompatinfo report, Missing Requires: php-pcre php-spl php-reflection [!]: Package complies to the Packaging Guidelines Please used normalized github URL https://fedoraproject.org/wiki/Packaging:SourceURL#Github ===== SHOULD items ===== [?]: Package does not generate any conflict. While /usr/share/php/lightncandy is fine for now (and seems ok with curent Guildelines) /usr/share/php/zordius-lightncandy or /usr/share/php/zordius/lightncandy seems better (this single class is not PSR-0 compliant...) ===== COULD items ===== An autoload is "perhaps" not required for a single class.. but this can change in the future (other classes, dependency), so could have some value. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review