[Bug 1219411] Review Request: python34 - Version 3 of the Python programming language aka Python 3000

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1219411



--- Comment #7 from Matej Stuchlik <mstuchli@xxxxxxxxxx> ---
Spec URL: https://mstuchli.fedorapeople.org/python34.spec
SRPM URL: https://mstuchli.fedorapeople.org/python34-3.4.3-2.fc21.src.rpm

I've updated the spec - an explanation of individual changes follows:


@@ -739,6 +739,9 @@ Patch202: 00202-fix-undefined-behaviour-
 # test_threading fails in koji dues to it's handling of signals
 Patch203: 00203-disable-threading-test-koji.patch

+# openssl requires DH keys to be > 768bits
+Patch204: 00204-increase-dh-keys-size.patch
+
 # (New patches go here ^^^)
 #
 # When adding new patches to "python" and "python3" in Fedora 17 onwards,

--> Related to https://bugs.python.org/issue23844

@@ -916,6 +919,12 @@ for f in md5module.c sha1module.c sha256
     rm Modules/$f
 done

+# Since we unbundle pip, our version is different from upstream
+%if 0%{with_rewheel}
+%global pip_version 7.0.3
+sed -r -i s/'_PIP_VERSION = "[0-9.]+"'/'_PIP_VERSION = "%{pip_version}"'/
Lib/ensurepip/__init__.py
+%endif
+
 #
 # Apply patches:
 #

--> Change a constant that holds version of pip that comes with our Python.
    This will need to be changed whenever we update pip.

@@ -1020,6 +1029,7 @@ done
 # 00199: doesn't apply to RHEL 7
 %patch202 -p1
 %patch203 -p1
+%patch204 -p1

--> Applying the DH patch

 # Currently (2010-01-15), http://docs.python.org/library is for 2.6, and there
@@ -1139,7 +1149,7 @@ BuildPython debug \
   "--with-pydebug --with-count-allocs --with-call-profile --without-ensurepip"
\
 %endif
   false \
-  -O1
+  -O0
 %endif # with_debug_build

 BuildPython optimized \
@@ -1219,7 +1229,7 @@ make altinstall \
 %if 0%{?with_debug_build}
 InstallPython debug \
   %{py_INSTSONAME_debug} \
-  -O1
+  -O0

--> Compile -debug build with -O0

 %if ! 0%{?main_python3}
 # altinstall only creates pkgconfig/python-3.4.pc, not the version with
ABIFAGS,
@@ -1483,7 +1493,9 @@ ln -s \
 #  python3X+1 stacks... I don't see any way in which this would be useful
 #  Gentoo does this, as well... TODO: there's a sysconfig variable pointing
 #  to this, maybe we should do something about it?
+%if ! 0%{?main_python3}
 rm -f %{buildroot}%{_libdir}/libpython3.so
+%endif

 # ======================================================
 # Running the upstream test suite

--> Looking into it further, we should keep libpython3.so in the main Python

@@ -1518,6 +1530,10 @@ CheckPython() {
   LD_LIBRARY_PATH=$ConfDir $ConfDir/python -m test.regrtest \
     --verbose --findleaks \
     -x test_distutils \

--> This test fails in Koji but works fine locally, I'll look into
    why that could be the case, but I think it's safe to disable it
    for now.

+    %if 0%{!with_rewheel}
+    -x test_ensurepip \
+    -x test_venv \
+    %endif
     %ifarch ppc64le aarch64
     -x test_faulthandler \
     %endif
@@ -1776,7 +1792,9 @@ rm -fr %{buildroot}

--> These failures are expected early in the bootstrap

 %{_libdir}/%{py_INSTSONAME_optimized}
 # removed in EPEL, see explanation in install section
-#%%{_libdir}/libpython3.so
+%if 0%{?main_python3}
+%{_libdir}/libpython3.so
+%endif
 %if 0%{?with_systemtap}
 %dir %(dirname %{tapsetdir})
 %dir %{tapsetdir}
@@ -1972,6 +1990,12 @@ rm -fr %{buildroot}
 # ======================================================

--> See above.

A Koji build is available at [0], hopefully everything is alright now. :)

[0] http://koji.fedoraproject.org/koji/taskinfo?taskID=10068934

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]