https://bugzilla.redhat.com/show_bug.cgi?id=1228924 --- Comment #8 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Gerald Cox from comment #7) > Location of source files: > > Spec URL: https://gbcox.fedorapeople.org/specs/megatools.spec > SRPM URL: https://gbcox.fedorapeople.org/copr/megatools-1.9.95-3.fc22.src.rpm > > Thanks Jerry! I went ahead and incorporated your optional recommendations. No problem. > Regarding REQUIRES: > I actually ran into this issue on another package. I was adding the > packages that were referenced in the BUILDREQUIRES. It was pointed out to > me that this was incorrect. Check out: > http://fedoraproject.org/wiki/Packaging:Guidelines#Requires > http://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires > The key quote: > "Packages must not contain unnecessary explicit Requires on libraries. We > generally rely on rpmbuild to automatically add dependencies on library > SONAMEs. Modern package management tools are capable of resolving such > dependencies to determine the required packages in many cases." Yes, for libraries that is correct. However, the gobject-introspection package is not a library, so dependencies on it are not auto-generated. Take a look at the list of Requires in comment 2. It isn't on that list. I don't think you want to make that a dependency anyway. I think you should make your package own those directories. If you check with rpm -qf, you'll see that many other packages have already done exactly this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review