https://bugzilla.redhat.com/show_bug.cgi?id=1175023 --- Comment #27 from Jerry James <loganjerry@xxxxxxxxx> --- Sorry for the delay. Real Life has been a pain the last few days. (In reply to Gerald Cox from comment #20) > Jerry, I'm open to suggestions. The problem is that the way github packages > the archives. It doesn't populate the submodules (in this case > tag_wrapper). You have to manually: submodule init and update to get it > included, then > re-create the archive. It's a known issue, people have been complaining, but > it still isn't fixed. I searched and searched and the only way I could find > to do it was to copy an approach used by another Fedora package (comment > #5). I don't particularly like it either, it's kind of a pain. You'd think > that > there would be a more elegant way to handle, but I haven't been able to find > it. Okay, I understand the issue with the tarball now, and your solution to the problem is reasonable. > On a previous review, I was told if something was listed in BuildRequires, > that the Requires are automatically provided, and to not double-list. Is > that not correct? That is correct in some circumstances, but not in this one. If you are building against a C or C++ library named foo, then BuildRequires: foo-devel is all you need, because the dependency generator can look at the list of libraries that your ELF objects are linked against and extract the necessary Requires. The perl dependency generator is able to do something similar in most circumstances (although it needs a helping hand once in awhile). Unfortunately, in the python world, this just doesn't happen. You have to list all of the Requires manually. Take a look: $ rpm -q --requires -p oggify-2.0.7-4.fc23.noarch.rpm/usr/bin/python2 flac python(abi) = 2.7 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 vorbis-tools There is no mention of python-mutagen. The rule is to examine the generated Requires after building and make sure everything your package needs is listed there. If it is, then great: the dependency generator figured it out for you. If not, then you have to list it manually in the spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review