[Bug 1230874] Review Request: felix-scr-maven-plugin - Maven plugin for generating OSGi Declarative Services annotations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1230874



--- Comment #19 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> ---
(In reply to gil cattaneo from comment #18)
> (In reply to Severin Gehwolf from comment #17)
> > > Please, not rename aid or gIg of the plugin, if this does not cause the
> > > failure of the build. This changes create difficulties in its use only and
> > > not meant to exist.
> > 
> > The aId:gId pairs have not been changed, but the proposed name of the
> > package in fedora (maven-scr-plugin vs. felix-src-maven-plugin). Changing
> > aId:gId would be something to do upstream first.
> 
> Then it makes few sense to rename the package.
> Needless to wrap your head if it is not broken. :)
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming

What's your point exactly? It's not in fedora yet, so IMHO it makes more sense
to call it <foo>-maven-plugin rather than maven-<foo>-plugin since it's not a
plugin with group ID org.apache.maven.plugins. Both would satisfy naming
guidelines. There are already example packages in fedora:
jetty-version-maven-plugin
port-allocator-maven-plugin
exec-maven-plugin
cobertura-maven-plugin

felix-scr-maven-plugin makes sense to me since it doesn't use gId
org.apache.maven.plugins but has org.apache.felix and it's actually an upstream
bug that they don't follow maven plug-in's naming conventions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]