https://bugzilla.redhat.com/show_bug.cgi?id=1226474 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Gerald Cox from comment #2) > Jerry, > Could you also explain carat.module.in (Source1:) - I having problems > figuring out where it is coming from? I've not had my coffee so maybe that > is the problem. ;-) > Also, please just review Comment 1. Strangely, those are related. :-) So carat.module.in is the source file for environment-modules. I wrote it myself. Consider it part of the Fedora packaging. It gives a user the ability to inject the directory containing the binaries from this package into PATH. That way, we avoid poisoning PATH with generically named binaries unless the user really, really wants them in PATH. > - Must: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. - File in tarball as > COPYING. > - Must: License file installed when any subpackage combination is installed. Yes, an oversight there. Corrected. > - Should: Uses parallel make %{?_smp_mflags} macro. Yes, unfortunately upstream's Makefile is broken in that regard. I haven't yet figured out how to fix it. > - Should: If the source package does not include license text(s) as a > separate > file from upstream, the packager SHOULD query upstream to include it. The source package does the license, I just forgot to include it in the rpm package. > - Should: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in carat- > tables , carat-doc This is on purpose. The carat-tables subpackage was separated out because it contains large noarch data, so the main package depends on it. The carat-doc package does not need anything else, since it contains only documentation. > - Should: SourceX is a working URL. No can do, since upstream doesn't give a hoot about environment-modules. New URLs: Spec URL: https://jjames.fedorapeople.org/carat/carat.spec SRPM URL: https://jjames.fedorapeople.org/carat/carat-2.1b1.19.07.2008-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review