https://bugzilla.redhat.com/show_bug.cgi?id=1228924 --- Comment #6 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Gerald Cox from comment #4) > Just checked and those directories I believe are owned by > gobject-introspection, which is in the BuildRequires. Yes, but it isn't in the Requires, which means that if this package is installed, but gobject-introspection is not, and this package is subsequently removed, those directories will stay behind. Either this package must also own those directories, or it needs to Requires: gobject-introspection. (In reply to Gerald Cox from comment #5) > I had a discussion with upstream: sjson.c isn't used by the build. > sjson.gen.c has references to sjson.c in line comments and that is > apparently why it is being picked up. Right, the debuginfo generator wants to see it, since sjson.gen.c refers to it. But that isn't critical. > Regarding libpthread it is pulled in by glib2 (via pkg-config), not by > megatools themselves, and it is used. Well, I see -pthread in the list of flags passed to gcc when the library is linked. Even if glib2 itself uses pthreads, apparently the library itself does not, which is why this is being marked as an unused direct dependency. This isn't critical enough to lose sleep over, though. On the other hand, it can be fixed by doing this between %configure and make: sed -i 's/\(GLIB_CFLAGS = \)-pthread/\1/' Makefile which appears to mean that this is a glib2 packaging bug. You can do that or not, at your discretion. > Thanks so much for your recommendation for the > unused-direct-shlib-dependency problems - that resolved the error messages. No problem. It looks like removing the rpath so early in the build process is now causing another issue, though. The Rawhide build is now failing when trying to link the binaries. I had to add this to the spec file right before the make invocation to review this version: export LD_LIBRARY_PATH=$PWD/.libs Also, I found that the these errors: ./libtool: line 7905: func_munge_path_list: command not found can be gotten rid of by running "autoreconf -fi" in %prep. Your choice whether you want to do that or not. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review