https://bugzilla.redhat.com/show_bug.cgi?id=1209366 --- Comment #5 from Antonio Trande <anto.trande@xxxxxxxxx> --- - update-desktop-database is not invoked http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database - 3rdparty/CGetOpt/CGetOpt.cpp is involved in the compilation. To me, License tag must include BSD too. http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Licensing_Scenario - It's available a most recent version. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in qmapshack See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://bitbucket.org/maproom/qmapshack/downloads/qmapshack-1.2.0.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: qmapshack-1.2.0-1.fc23.x86_64.rpm qmapshack-1.2.0-1.fc23.src.rpm qmapshack.x86_64: W: spelling-error %description -l en_US img -> mg, imp, i mg qmapshack.src: W: spelling-error %description -l en_US img -> mg, imp, i mg qmapshack.src: W: invalid-url Source0: https://bitbucket.org/maproom/qmapshack/downloads/qmapshack-1.2.0.tar.gz HTTP Error 404: NOT FOUND 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: qmapshack-debuginfo-1.2.0-1.fc23.x86_64.rpm qmapshack-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/qmapshack-1.2.0/src/units/CUnitNautic.cpp qmapshack-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/qmapshack-1.2.0/src/units/IUnit.cpp qmapshack-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/qmapshack-1.2.0/src/units/CUnitMetric.cpp qmapshack-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/qmapshack-1.2.0/src/units/CUnitImperial.cpp qmapshack-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/qmapshack-1.2.0/src/units/CUnitMetric.h qmapshack-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/qmapshack-1.2.0/src/units/CUnitImperial.h qmapshack-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/qmapshack-1.2.0/src/units/IUnit.h qmapshack-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/qmapshack-1.2.0/src/units/CUnitNautic.h 1 packages and 0 specfiles checked; 8 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- INFO: mock.py version 1.2.9 starting (python version = 3.4.2)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled ccache Mock Version: 1.2.9 INFO: Mock Version: 1.2.9 Traceback (most recent call last): File "/usr/sbin/mock", line 831, in <module> main() File "/usr/lib/python3.4/site-packages/mockbuild/trace_decorator.py", line 84, in trace result = func(*args, **kw) File "/usr/sbin/mock", line 653, in main run_command(options, args, config_opts, commands, buildroot, state) File "/usr/lib/python3.4/site-packages/mockbuild/trace_decorator.py", line 84, in trace result = func(*args, **kw) File "/usr/sbin/mock", line 708, in run_command commands.init() File "/usr/lib/python3.4/site-packages/mockbuild/trace_decorator.py", line 84, in trace result = func(*args, **kw) File "/usr/lib/python3.4/site-packages/mockbuild/backend.py", line 123, in init self.buildroot.initialize(**kwargs) File "/usr/lib/python3.4/site-packages/mockbuild/trace_decorator.py", line 84, in trace result = func(*args, **kw) File "/usr/lib/python3.4/site-packages/mockbuild/buildroot.py", line 84, in initialize self._init(prebuild=prebuild, do_log=do_log) File "/usr/lib/python3.4/site-packages/mockbuild/trace_decorator.py", line 84, in trace result = func(*args, **kw) File "/usr/lib/python3.4/site-packages/mockbuild/buildroot.py", line 128, in _init self._setup_devices() File "/usr/lib/python3.4/site-packages/mockbuild/trace_decorator.py", line 84, in trace result = func(*args, **kw) File "/usr/lib/python3.4/site-packages/mockbuild/buildroot.py", line 442, in _setup_devices os.symlink("/proc/self/mounts", self.make_chroot_path('etc', 'mtab')) FileExistsError: [Errno 17] File exists: '/proc/self/mounts' -> '/var/lib/mock/fedora-rawhide-x86_64/root/etc/mtab' Requires -------- qmapshack (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5DBus.so.5()(64bit) libQt5Gui.so.5()(64bit) libQt5Network.so.5()(64bit) libQt5PrintSupport.so.5()(64bit) libQt5Script.so.5()(64bit) libQt5Sql.so.5()(64bit) libQt5WebKit.so.5()(64bit) libQt5WebKitWidgets.so.5()(64bit) libQt5Widgets.so.5()(64bit) libQt5Xml.so.5()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdal.so.1()(64bit) libm.so.6()(64bit) libproj.so.9()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) proj-epsg rtld(GNU_HASH) Provides -------- qmapshack: application() application(qmapshack.desktop) mimehandler(application/x-gpx) qmapshack qmapshack(x86-64) Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1209366 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review