https://bugzilla.redhat.com/show_bug.cgi?id=1228924 --- Comment #3 from Gerald Cox <gbcox@xxxxxx> --- (In reply to Jerry James from comment #2) > Issues: > ======= > - Almost the entire distribution is GPLv2+, but libtools/sjson.h is GPLv3+, > which makes the binary package GPLv3+ as well. You're correct... I'll make the change. > > - The package uses two directories that it does not own: > %{_libdir}/girepository-1.0 > %{_datadir}/gir-1.0 > The package needs to either own those directories or Requires: some package > that owns them. Missed that... OK... > > - The build runs in quiet mode, which makes verifying the compiler flags > hard. Please consider either configuring with --disable-silent-rules, > or building with make V=1. OK > > - You can save time building a static archive and then deleting it in > %install > by passing --disable-static to %configure. OK > > - The build log shows two complaints from the debuginfo generator: > > cpio: megatools-1.9.95/sjson.c: Cannot stat: No such file or directory > cpio: megatools-1.9.95/sjson.gen.c: Cannot stat: No such file or directory I'll look into it. > > You can get slightly better debuginfo by adding this to the end of > %install: > > ln -s libtools/sjson.gen.c . > > Unfortunately, the original sjson.c does not appear to be available. Will investigate. > > - rpmlint finds binary-or-shlib-defines-rpath problems with the binaries, > which apparently means the "find ... chrpath" invocation in %install didn't > work. I don't know why not, but these approaches work: > https://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath > > But see the next item. > > - The unused-direct-shlib-dependency problems can usually be fixed by adding > -Wl,--as-needed to LDFLAGS. Unfortunately, libtool cleverly reorders link > flags and puts -Wl,--as-needed *after* the extraneous libraries, rendering > it useless. I do this after %configure in several of my packages to solve > both the previous problem and this one: > > # Get rid of undesirable hardcoded runpaths; workarouond libtool reordering > # -Wl,--as-needed after all the libraries. > sed -e 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' \ > -e 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' \ > -e 's|CC="\(g.*\)"|CC="\1 -Wl,--as-needed"|' \ > -i libtool > > That still leaves a direct unused dependency from the library on > libpthread.so.0, so apparently the library does not need to be linked with > the -pthread option. Yeah, I was thinking the chrpath would handle that. I'll review. > > - Since TODO is an empty file, there is not much point including it in %doc. I'll remove it. > > - Consider adding a %check script. I see a couple of binaries in tests > (test-aes and test-rsa), as well as a handful of scripts. I'll look into it. > -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review