[Bug 1175023] Review Request: oggify - audio conversion tool for music library conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1175023



--- Comment #18 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Ralf Corsepius from comment #16)
> [MUSTFIX] 
> Package name does not comply to Fedora package naming conventions. Please
> rename this package.
> 
> It's Fedora convention to name packages after the upstream tarball's name,
> which as I understand your spec is "Oggify":
> ...
> %global project		Oggify	
> ..
> Source0:	http://gbcox.fedorapeople.org/%{name}/%{project}-%{version}.tar.gz
> ...
> 
> If you want to, you can add "oggify*" through appropriate explicit
> "Provides", instead.

This is not consistent with the package naming guidelines, which express a
preference for lower-case names:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Case_Sensitivity.

A case could be made for requiring the name to be "python-oggify" or
"python-Oggify", since the package ships a python egg.  However, since the
package also contains a binary in %{_bindir}, the packaging guidelines give
enough latitude for the maintainer to choose any of these names, at the
maintainer's discretion:
- oggify
- Oggify
- python-oggify
- python-Oggify

It's really up to you, Gerald, although if upstream has expressed a preference
with regards to capitalization, that would carry a lot of weight.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]