https://bugzilla.redhat.com/show_bug.cgi?id=1228163 Alan Pevec <apevec@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Alan Pevec <apevec@xxxxxxxxx> --- Approved, there are improvements which can be added later (SHOULD items): - add %check section - no-manual-page-for-binary and no-documentation rpmlint warnings Package Review Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. designate-2015.1.0/designate/api/v2/controllers/rest.py is BSD (3 clause) which can be relicensed as ASL 2.0 [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. NB fedora-review reports "rm -rf %{buildroot} present but not required" but removals under # Remove unused files are fine! [x]: Sources contain only permissible code or content. [x]: %config files are marked noreplace or the reason is justified. /etc/sudoers.d/designate is not noreplace which came from Neutron, argumentation in https://bugzilla.redhat.com/show_bug.cgi?id=1039817#c16 [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Subpackages do have versioned dep: python-%{service} = %{version}-%{release} [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). E: non-standard-dir-perm /var/log/designate 0750L This is intentional, logs should not be world-readable... E: non-readable /usr/share/designate/designate-dist.conf 0640L E: non-readable /etc/designate/designate.conf 0640L E: non-readable /etc/sudoers.d/designate 0440L ...same for configs E: incoherent-logrotate-file /etc/logrotate.d/openstack-designate File is in -common subpackage so rpmlint got confused https://fedoraproject.org/wiki/Common_Rpmlint_issues#incoherent-logrotate-file [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-designate-2015.1.0-1.fc23.noarch.rpm python-designate-tests-2015.1.0-1.fc23.noarch.rpm openstack-designate-common-2015.1.0-1.fc23.noarch.rpm openstack-designate-agent-2015.1.0-1.fc23.noarch.rpm openstack-designate-api-2015.1.0-1.fc23.noarch.rpm openstack-designate-central-2015.1.0-1.fc23.noarch.rpm openstack-designate-mdns-2015.1.0-1.fc23.noarch.rpm openstack-designate-pool-manager-2015.1.0-1.fc23.noarch.rpm openstack-designate-sink-2015.1.0-1.fc23.noarch.rpm openstack-designate-2015.1.0-1.fc23.src.rpm python-designate.noarch: W: no-documentation python-designate-tests.noarch: W: no-documentation python-designate-tests.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/designate/tests/resources/ssl/nsd_server.pem python-designate-tests.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/designate/tests/resources/ssl/nsd_control.pem openstack-designate-common.noarch: W: conffile-without-noreplace-flag /etc/sudoers.d/designate openstack-designate-common.noarch: W: non-standard-uid /var/log/designate designate openstack-designate-common.noarch: W: non-standard-gid /var/log/designate designate openstack-designate-common.noarch: E: non-standard-dir-perm /var/log/designate 0750L openstack-designate-common.noarch: W: non-standard-gid /usr/share/designate/designate-dist.conf designate openstack-designate-common.noarch: E: non-readable /usr/share/designate/designate-dist.conf 0640L openstack-designate-common.noarch: W: non-standard-uid /var/lib/designate designate openstack-designate-common.noarch: W: non-standard-gid /var/lib/designate designate openstack-designate-common.noarch: W: non-standard-gid /etc/designate/designate.conf designate openstack-designate-common.noarch: E: non-readable /etc/designate/designate.conf 0640L openstack-designate-common.noarch: E: non-readable /etc/sudoers.d/designate 0440L openstack-designate-common.noarch: E: incoherent-logrotate-file /etc/logrotate.d/openstack-designate openstack-designate-common.noarch: W: no-manual-page-for-binary designate-rootwrap openstack-designate-agent.noarch: W: no-documentation openstack-designate-agent.noarch: W: no-manual-page-for-binary designate-agent openstack-designate-api.noarch: W: no-documentation openstack-designate-api.noarch: W: non-standard-gid /usr/share/designate/api-paste.ini designate openstack-designate-api.noarch: W: non-standard-gid /etc/designate/policy.json designate openstack-designate-api.noarch: E: non-readable /etc/designate/policy.json 0640L openstack-designate-api.noarch: W: no-manual-page-for-binary designate-api openstack-designate-central.noarch: W: no-documentation openstack-designate-central.noarch: W: no-manual-page-for-binary designate-manage openstack-designate-central.noarch: W: no-manual-page-for-binary designate-central openstack-designate-mdns.noarch: W: no-documentation openstack-designate-mdns.noarch: W: no-manual-page-for-binary designate-mdns openstack-designate-pool-manager.noarch: W: no-documentation openstack-designate-pool-manager.noarch: W: no-manual-page-for-binary designate-pool-manager openstack-designate-sink.noarch: W: no-documentation openstack-designate-sink.noarch: W: no-manual-page-for-binary designate-sink 10 packages and 0 specfiles checked; 6 errors, 27 warnings. Rpmlint (installed packages) ---------------------------- openstack-designate-agent.noarch: W: no-documentation openstack-designate-agent.noarch: W: no-manual-page-for-binary designate-agent openstack-designate-mdns.noarch: W: no-documentation openstack-designate-mdns.noarch: W: no-manual-page-for-binary designate-mdns openstack-designate-central.noarch: W: no-documentation openstack-designate-central.noarch: W: no-manual-page-for-binary designate-manage openstack-designate-central.noarch: W: no-manual-page-for-binary designate-central openstack-designate-common.noarch: W: conffile-without-noreplace-flag /etc/sudoers.d/designate openstack-designate-common.noarch: W: non-standard-uid /var/log/designate designate openstack-designate-common.noarch: W: non-standard-gid /var/log/designate designate openstack-designate-common.noarch: E: non-standard-dir-perm /var/log/designate 0750L openstack-designate-common.noarch: W: non-standard-gid /usr/share/designate/designate-dist.conf designate openstack-designate-common.noarch: E: non-readable /usr/share/designate/designate-dist.conf 0640L openstack-designate-common.noarch: W: non-standard-uid /var/lib/designate designate openstack-designate-common.noarch: W: non-standard-gid /var/lib/designate designate openstack-designate-common.noarch: W: non-standard-gid /etc/designate/designate.conf designate openstack-designate-common.noarch: E: non-readable /etc/designate/designate.conf 0640L openstack-designate-common.noarch: E: non-readable /etc/sudoers.d/designate 0440L openstack-designate-common.noarch: E: incoherent-logrotate-file /etc/logrotate.d/openstack-designate openstack-designate-common.noarch: W: no-manual-page-for-binary designate-rootwrap python-designate-tests.noarch: W: no-documentation python-designate-tests.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/designate/tests/resources/ssl/nsd_server.pem python-designate-tests.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/designate/tests/resources/ssl/nsd_control.pem openstack-designate-pool-manager.noarch: W: no-documentation openstack-designate-pool-manager.noarch: W: no-manual-page-for-binary designate-pool-manager openstack-designate-api.noarch: W: no-documentation openstack-designate-api.noarch: W: non-standard-gid /usr/share/designate/api-paste.ini designate openstack-designate-api.noarch: W: non-standard-gid /etc/designate/policy.json designate openstack-designate-api.noarch: E: non-readable /etc/designate/policy.json 0640L openstack-designate-api.noarch: W: no-manual-page-for-binary designate-api openstack-designate-sink.noarch: W: no-documentation openstack-designate-sink.noarch: W: no-manual-page-for-binary designate-sink python-designate.noarch: W: no-documentation 9 packages and 0 specfiles checked; 6 errors, 27 warnings. Requires -------- openstack-designate-agent (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 openstack-designate-common openstack-designate-mdns (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 MySQL-python openstack-designate-common openstack-designate-central (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 MySQL-python openstack-designate-common openstack-designate-common (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 config(openstack-designate-common) python-designate python-designate-tests (rpmlib, GLIBC filtered): python(abi) python-designate openstack-designate-pool-manager (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 openstack-designate-common openstack-designate-api (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 config(openstack-designate-api) openstack-designate-common openstack-designate-sink (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 openstack-designate-common python-designate (rpmlib, GLIBC filtered): python(abi) python-babel python-dns python-eventlet python-flask python-greenlet python-iso8601 python-jinja2 python-jsonschema python-keystonemiddleware python-memcached python-migrate python-netaddr python-neutronclient python-oslo-concurrency python-oslo-config python-oslo-context python-oslo-db python-oslo-i18n python-oslo-log python-oslo-messaging python-oslo-middleware python-oslo-policy python-oslo-rootwrap python-oslo-serialization python-oslo-utils python-paste python-paste-deploy python-pbr python-pecan python-psutil python-requests python-routes python-six python-sqlalchemy python-stevedore python-webob python-werkzeug sudo Provides -------- openstack-designate-agent: openstack-designate-agent openstack-designate-mdns: openstack-designate-mdns openstack-designate-central: openstack-designate-central openstack-designate-common: config(openstack-designate-common) openstack-designate-common python-designate-tests: python-designate-tests openstack-designate-pool-manager: openstack-designate-pool-manager openstack-designate-api: config(openstack-designate-api) openstack-designate-api openstack-designate-sink: openstack-designate-sink python-designate: python-designate Source checksums ---------------- https://launchpad.net/designate/kilo/2015.1.0/+download/designate-2015.1.0.tar.gz : CHECKSUM(SHA256) this package : d4a2f3dfa6ed5bfef1c1d535bf1b0391317dd26e37ede6e901223a99a8d6bd8c CHECKSUM(SHA256) upstream package : d4a2f3dfa6ed5bfef1c1d535bf1b0391317dd26e37ede6e901223a99a8d6bd8c Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -b 1228163 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review