[Bug 1229518] Unretiring gdesklets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1229518



--- Comment #8 from gil cattaneo <puntogil@xxxxxxxxx> ---
Issues:

https://fedoraproject.org/wiki/Packaging:AppData
"If a package contains a GUI application, then it SHOULD also install a
.appdata.xml file into %{_datadir}/appdata/. Installed .appdata.xml files MUST
follow the AppData specification page."

you should add a similar file, with the procedures reported in the above page

NOTE: i never used this software, please change "FIXME" with appropriate value

<?xml version="1.0" encoding="UTF-8"?>
​<component type="FIXME">
​  <id>gdesklets</id>
​  <extends>gdesklets.desktop</extends>
​  <name>gDesklets</name>
​  <summary>FIXME</summary>
​  <url type="homepage">https://launchpad.net/gdesklets</url>
​  <url type="bugtracker">https://bugs.launchpad.net/gdesklets</url>
​  <metadata_license>FIXME</metadata_license>
​  <project_license>GPL-2.0+</project_license>
​</component>

BuildRequires:  libappstream-glib

install -Dp %{SOURCE1} %{buildroot}/%{_datadir}/appdata/%{name}.appdata.xml
%endif

appstream-util validate-relax --nonet
%{buildroot}/%{_datadir}/appdata/%{name}.appdata.xml

and request to upstream to integrate it in their distribution
https://fedoraproject.org/wiki/Packaging:AppData#.metainfo.xml_file_creation

NON blocking issues:
gdesklets.i686: E: incorrect-fsf-address /usr/share/doc/gdesklets/COPYING
gdesklets-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/gdesklets-0.36.3/utils/svg.c
gdesklets-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/gdesklets-0.36.3/utils/x11.c
gdesklets-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/gdesklets-0.36.3/libdesklets/system/gtop.c

https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
Please, report to upstream the problem

desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
is unnecessary, cause desktop-file-install already validate the .desktop file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]