Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Crypt-OpenSSL-RSA -- Perl OpenSSL bindings for RSA support https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237334 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-05-26 02:16 EST ------- I put the dependencies in a local repo so I could get this built. It will be nice when rawhide is rawhide again. I note that 0.25 has come out since you submitted this review. (It never fails.) I don't think it will significantly affect the packaging, but I note that the author has added a LICENSE file which you will need to package. I'll proceed to review 0.24 but if you'd like me to review a 0.25 package as well, just post it and I'll do so. * source files match upstream: 5de946bf19cd96317418a422a44cb0ebea6e17e42ef1485489e67df0a6acb259 Crypt-OpenSSL-RSA-0.24.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper (including all modules used by the tests) * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: RSA.so()(64bit) perl(Crypt::OpenSSL::RSA) = 0.24 perl-Crypt-OpenSSL-RSA = 0.24-3.fc7 = libcrypto.so.6()(64bit) libssl.so.6()(64bit) perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(Carp) perl(Crypt::OpenSSL::Random) perl(DynaLoader) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=3, Tests=137, 1 wallclock secs ( 0.20 cusr + 0.03 csys = 0.23 CPU) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la droppings. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review