Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qgis - A user friendly Open Source Geographic Information System https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241403 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-05-25 19:37 EST ------- Some initial comments: First please check: http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines Then: * Please write all BuildRequires in main section. * %makeinstall is highly forbidden. * stripping binaries is strictly forbidden to create debuginfo rpm * For python/test_export.py, verify which is proper, to make this script have executable permission, or to remove shebang. * Fix directory ownership. For example, %{_libdir}/%{name} is not owned by any package. * Shipping static archive is highly forbidden unless you have some reasonable reason. * Also shipping libtool archive is highly forbidden. * %defattr(-, root, root, -) is recommended * Using disttag is recommended I just glanced at your spec file and I didn't try to rebuild this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review