https://bugzilla.redhat.com/show_bug.cgi?id=1224574 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- It's not an area I know anything about, but since there are no takers, I'll do the review... At first sight: Can you beef up %description? "cloud" is a popular yet nebulous term, and I think some explanation in the form "This allows you to ..." would be great. owncloud-news.noarch: E: version-control-internal-file /usr/share/owncloud/apps/news/vendor/ezyang/htmlpurifier/.gitignore owncloud-news.noarch: E: version-control-internal-file /usr/share/owncloud/apps/news/vendor/fguillot/picofeed/.gitignore owncloud-news.noarch: W: hidden-file-or-dir /usr/share/owncloud/apps/news/js/.jshintrc owncloud-news.noarch: W: hidden-file-or-dir /usr/share/owncloud/apps/news/l10n/.tx owncloud-news.noarch: W: hidden-file-or-dir /usr/share/owncloud/apps/news/l10n/.tx owncloud-news.noarch: W: hidden-file-or-dir /usr/share/owncloud/apps/news/l10n/.gitkeep owncloud-news.noarch: E: zero-length /usr/share/owncloud/apps/news/l10n/.gitkeep owncloud-news.noarch: W: hidden-file-or-dir /usr/share/owncloud/apps/news/js/vendor/angular-mocks/.bower.json ... So .gitignores and .gitkeeps should be removed. Other hidden files: dunno. owncloud-news.noarch: E: non-executable-script /usr/share/owncloud/apps/news/vendor/ezyang/htmlpurifier/maintenance/update-freshmeat.php 0644L /usr/bin/php owncloud-news.noarch: E: non-executable-script /usr/share/owncloud/apps/news/vendor/ezyang/htmlpurifier/maintenance/old-remove-require-once.php 0644L /usr/bin/php If those are supposed to be run by the admin, then chmod +x. -exec rm -f {} → -delete ? Requires -------- owncloud-news (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/env /usr/bin/php /usr/bin/python3 /usr/share/owncloud/apps/news/vendor/fguillot/picofeed/picofeed:#!/usr/bin/env php /usr/lib/python3.4/site-packages/owncloud_news_updater/application.py:#!/usr/bin/env python3 /usr/lib/python3.4/site-packages/owncloud_news_updater/updater.py:#!/usr/bin/env python3 I'd change those to /usr/bin/php and %{__python3}. Just to keep things clean and match other files. /usr/share/licenses/owncloud-news/{COPYING,LICENSE.txt} are duplicated. Just one should be enough. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review