[Bug 1222926] Review Request: nunit - unit-testing framework for .Net/mono

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1222926



--- Comment #2 from Claudio Rodrigo Pereyra DIaz <claudiorodrigo@xxxxxxxxxxxxxxxxxx> ---
Some suggestion

- Remove defatt, is no used any more
%defattr(-,root,root)

- devel package must require %{?_isa}
Requires:       %{name}%{?_isa} = %{version}-%{release}

Source have a license.txt, this should be included with 
%licesen

You should use mono macros
%{_monogacdir} instead %{_libdir}/mono/gac
%{_monodir} instead %{_libdir}/mono
see https://fedoraproject.org/wiki/Packaging:Mono#File_Locations

Script name is beter not use . and - only the number
`basename -s .sh %{SOURCE2}`26 instead `basename -s .sh %{SOURCE2}`-2.6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]