https://bugzilla.redhat.com/show_bug.cgi?id=1146181 Jan Holcapek <holcapek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jan Holcapek <holcapek@xxxxxxxxx> --- No blockers, just a few questions/suggestions. - rpmlint on both source and binary rpms looks good. - Great idea of providing a sample config odbc.ini.sample! - Any special reason to require files (%{_bindir}/iconv, %{_bindir}/odbcinst}) rather than packages (glibc-common, unixODBC, respectively)? - Ad "correct EOL" in %prep: wouldn't dos2unix do the work more easily? - Ad checking executable odbcinst in %post and %preun is not required, since there is a dependency to %{_bindir}/odbcinst, right? (And thus "true" at the end of %post and %preun is not necessary, too.) - The upstream src rpm comes with quite old libtool; shouldn't we consider using the one from the distribution? That would require setting a new build-time dependency and patching Makefile. Anyway, good job! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review