https://bugzilla.redhat.com/show_bug.cgi?id=1178162 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |springframework-data-common |springframework-data-common |s - Interfaces and code |s - Interfaces between |shared between the various |relational and |datastore specific |non-relational data stores |implementations | --- Comment #7 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Jerry James from comment #6) > There are a few small SHOULD issues, which do not block approval, namely: > - Patches link to upstream bugs/comments/lists or are otherwise justified. The comment "Port to querydsl 4.0.0" is not enough? Upstream is already aware of the problem. But for this release there is nothing to do > - The spec file in the link and the spec file in the source rpm differ, so > be sure to check in the right one. Fixed > - If you want to preserve timestamps on license.txt and notice.txt, replace > these two lines in %prep: Timestamps should be stored using the macros (%doc %license) ..., or not? > This package is APPROVED. Thanks for the review! Spec URL: https://gil.fedorapeople.org/springframework-data-commons.spec SRPM URL: https://gil.fedorapeople.org/springframework-data-commons-1.8.4-2.fc20.src.rpm - summary changed in "Interfaces between relational and non-relational data stores" - cleanup spec file - fix some rpmlint problems -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review