https://bugzilla.redhat.com/show_bug.cgi?id=1079064 --- Comment #22 from Jason Tibbitts <tibbs@xxxxxxxxxxx> --- Yeah, one package review per ticket. Let me know what it is and I'll take care of it as well. I can make a couple of comments now, though: If you've forked SDL_mng, I'm happy with that though it would be nice to document it. Maybe one day you can re-merge with upstream. You shouldn't need to use %defattr. You really shouldn't use %makeinstall unless you don't have much choice: http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used If the proper way with DESTDIR doesn't work, at least document that in your spec. You shouldn't generally package libtool archives (.la files). As for mingw, I don't know much about it but there's a list at https://lists.fedoraproject.org/mailman/listinfo/mingw and an IRC channel with a few people in at at #fedora-mingw on freenode. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review