[Bug 1220779] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1220779



--- Comment #7 from Ding-Yi Chen <dchen@xxxxxxxxxx> ---
(In reply to Raphael Groner from comment #6)
> Two more informal things to mention:
> 
> > Patch0: %{name}-formatSecurity.patch
> Where do you have this patch from? Did you try to send it to upstream? If it
> can be found there, please provide a link, either directly the URL as value
> or another link in the comment.

This patch is to fix the compile error when -Werror=format-security is on.
The bug report and the patch is at:
https://sourceforge.net/p/skfans/bugs/4/


> Please remove the rm line from %install, you can move it to %clean. Note
> that this section is now redundant in Fedora and is only necessary for EPEL6.

Done.

> I could do the official review. But as I am on vacation currently, this is
> going to happen not before in the next weeks.

It is OK for me.

Spec URL: https://dchen.fedorapeople.org/files/rpms/7kaa.spec
SRPM URL: https://dchen.fedorapeople.org/files/rpms/7kaa-2.14.5-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]