https://bugzilla.redhat.com/show_bug.cgi?id=1174290 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Dave Love from comment #4) > (In reply to Vladimir Stackov from comment #3) > > > https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean > > Yes, but I'm doing what the packaging guidelines say by using a template and > rpmlint. This seems harmless and trivial in comparison to feedback I was > hoping for before doing similar tools. Less is better. It is easier to read (or review) the spec file if it doesn't contain unnecessary elements. The guidelines are normative, and rpmlint and templates are often out of date. Similarly for BuildRoot tag: please remove it. > > https://fedorahosted.org/fpc/ticket/411 > > https://fedoraproject.org/wiki/Changes/ > > Use_license_macro_in_RPMs_for_packages_in_Cloud_Image > > I can't tell what the status of that is, even. It's not in the guidelines, > I haven't seen anything use it, and I don't understand what you gain by > substituting the contents of the license tag somewhere. I want to include > actual documents, which aren't necessarily just the GPL, or whatever. Please see https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text. Using %license is now mandatory. It does not substitute the file, just changes the location and makes rpm install it even if docs are excluded. If you want to retain compatibility with older releases, you can use: %files %{!?_licensedir:%global license %%doc} %license COPYING It's a question of preference, but I'd change stuff like: for d in openmpi \ %if %{with mpich} mpich %endif do pushd $d make install DESTDIR=$RPM_BUILD_ROOT popd done to %makeinstall -C openmpi %if %{with mpich} %makeinstall -C mpich %endif ... just to be easier on the eyes :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review